-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not override GORELEASER_CURRENT_TAG #370
Conversation
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
=======================================
Coverage 66.14% 66.14%
=======================================
Files 4 4
Lines 127 127
Branches 23 23
=======================================
Hits 84 84
Misses 25 25
Partials 18 18 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yes this was added to ease the integration in the workflow otherwise |
at this point, I think we could actually make the action simpler and just download and run goreleaser without doing anything else. we don't even need javascript for that, see https://github.com/sigstore/cosign-installer/blob/main/action.yml for example |
cc/ @cpanato since you maintain the cosign action... anything you would like to share about your approach? does it work well? anything you wish to have done differently? do you automate the action release et al? thankss <3 |
my personal option is either you just have an action to install the tool and make sure you are installing correctly (checking signatures/shasums...) or you are very opinionated in how to expose the options to run the tool, otherwise, you will have to maintain a lot of corner cases and some are just for a really smaller audience. |
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@crazy-max FWIW gonna release this |
@caarlos0 Major bump was the right move, thanks! |
in v4, `goreleaser` made a breaking change ``` executing "tmpl" at <.Env.GORELEASER_CURRENT_TAG>: map has no entry for key "GORELEASER_CURRENT_TAG" ``` goreleaser/goreleaser-action#370 we'll have to look into that how we can use it in v4
## [1.4.0](v1.3.3...v1.4.0) (2023-01-01) ### 👷 Build System * **deps-dev:** Bump @semantic-release/changelog from 6.0.1 to 6.0.2 ([#404](#404)) ([ee56dbc](ee56dbc)), closes [#276](#276) [#276](#276) [#272](#272) [#275](#275) [#273](#273) [#274](#274) [#271](#271) [#270](#270) [#269](#269) [#268](#268) [#267](#267) ### 🎉 Features * add custom tags to created ECR repositories ([#191](#191)) ([9849df2](9849df2)) ### 📝 Documentation * fix indentation ([b00c57e](b00c57e)) ### ⬆️ Dependencies * **deps:** Bump actions/cache from 3.0.11 to 3.2.1 ([#417](#417)) ([7e7eb8f](7e7eb8f)), closes [actions/cache#1039](actions/cache#1039) [actions/cache#1023](actions/cache#1023) [actions/cache#959](actions/cache#959) [actions/cache#960](actions/cache#960) [actions/cache#963](actions/cache#963) [actions/cache#961](actions/cache#961) [actions/cache#976](actions/cache#976) [actions/cache#971](actions/cache#971) [actions/cache#979](actions/cache#979) [actions/cache#986](actions/cache#986) [actions/cache#981](actions/cache#981) [actions/cache#997](actions/cache#997) [actions/cache#998](actions/cache#998) [actions/cache#1005](actions/cache#1005) [actions/cache#1007](actions/cache#1007) [actions/cache#1013](actions/cache#1013) [actions/cache#1004](actions/cache#1004) [actions/cache#1014](actions/cache#1014) [actions/cache#1008](actions/cache#1008) [actions/cache#1026](actions/cache#1026) [actions/cache#929](actions/cache#929) [actions/cache#1035](actions/cache#1035) [actions/cache#959](actions/cache#959) [actions/cache#979](actions/cache#979) [actions/cache#1013](actions/cache#1013) [actions/cache#1026](actions/cache#1026) [actions/cache#929](actions/cache#929) [actions/cache#1006](actions/cache#1006) [#1023](https://github.com/estahn/k8s-image-swapper/issues/1023) [#1039](https://github.com/estahn/k8s-image-swapper/issues/1039) [#1035](https://github.com/estahn/k8s-image-swapper/issues/1035) [#929](https://github.com/estahn/k8s-image-swapper/issues/929) [#1026](https://github.com/estahn/k8s-image-swapper/issues/1026) [#1008](https://github.com/estahn/k8s-image-swapper/issues/1008) [#1014](https://github.com/estahn/k8s-image-swapper/issues/1014) [#1004](https://github.com/estahn/k8s-image-swapper/issues/1004) * **deps:** Bump actions/setup-python from 4.3.0 to 4.3.1 ([#406](#406)) ([16da762](16da762)), closes [actions/setup-python#559](actions/setup-python#559) [actions/setup-python#511](actions/setup-python#511) [actions/setup-python#558](actions/setup-python#558) [#559](#559) [#558](#558) [#549](#549) [#546](#546) [#545](#545) [#535](#535) [#510](#510) [#511](#511) [#520](#520) * **deps:** Bump actions/setup-python from 4.3.1 to 4.4.0 ([#418](#418)) ([77872f8](77872f8)), closes [actions/setup-python#566](actions/setup-python#566) [#567](#567) [#569](#569) [#566](#566) * **deps:** Bump github.com/aws/aws-sdk-go from 1.44.146 to 1.44.152 ([#403](#403)) ([9db51fd](9db51fd)), closes [#4652](https://github.com/estahn/k8s-image-swapper/issues/4652) [#4650](https://github.com/estahn/k8s-image-swapper/issues/4650) [#4648](https://github.com/estahn/k8s-image-swapper/issues/4648) [#4647](https://github.com/estahn/k8s-image-swapper/issues/4647) [#4646](https://github.com/estahn/k8s-image-swapper/issues/4646) [#4644](https://github.com/estahn/k8s-image-swapper/issues/4644) [#4639](https://github.com/estahn/k8s-image-swapper/issues/4639) * **deps:** Bump github.com/aws/aws-sdk-go from 1.44.152 to 1.44.157 ([#411](#411)) ([2188432](2188432)), closes [#4658](https://github.com/estahn/k8s-image-swapper/issues/4658) [#4657](https://github.com/estahn/k8s-image-swapper/issues/4657) [#4656](https://github.com/estahn/k8s-image-swapper/issues/4656) [#4654](https://github.com/estahn/k8s-image-swapper/issues/4654) [#4653](https://github.com/estahn/k8s-image-swapper/issues/4653) * **deps:** Bump github.com/aws/aws-sdk-go from 1.44.157 to 1.44.162 ([#415](#415)) ([f70fcd9](f70fcd9)), closes [#4666](https://github.com/estahn/k8s-image-swapper/issues/4666) [#4665](https://github.com/estahn/k8s-image-swapper/issues/4665) [#4663](https://github.com/estahn/k8s-image-swapper/issues/4663) [#4661](https://github.com/estahn/k8s-image-swapper/issues/4661) [#4660](https://github.com/estahn/k8s-image-swapper/issues/4660) * **deps:** Bump github.com/aws/aws-sdk-go from 1.44.162 to 1.44.167 ([#419](#419)) ([f8b91fe](f8b91fe)), closes [#4671](https://github.com/estahn/k8s-image-swapper/issues/4671) [#4670](https://github.com/estahn/k8s-image-swapper/issues/4670) [#4669](https://github.com/estahn/k8s-image-swapper/issues/4669) [#4668](https://github.com/estahn/k8s-image-swapper/issues/4668) [#4667](https://github.com/estahn/k8s-image-swapper/issues/4667) * **deps:** Bump github.com/gruntwork-io/terratest from 0.41.3 to 0.41.4 ([#402](#402)) ([16dde07](16dde07)), closes [#1208](https://github.com/estahn/k8s-image-swapper/issues/1208) * **deps:** Bump github.com/gruntwork-io/terratest from 0.41.4 to 0.41.6 ([#409](#409)) ([9fc87df](9fc87df)), closes [#1214](https://github.com/estahn/k8s-image-swapper/issues/1214) [#1198](https://github.com/estahn/k8s-image-swapper/issues/1198) * **deps:** Bump github.com/gruntwork-io/terratest from 0.41.6 to 0.41.7 ([#420](#420)) ([9ab97f2](9ab97f2)), closes [gruntwork-io/terratest#1217](gruntwork-io/terratest#1217) [#1217](https://github.com/estahn/k8s-image-swapper/issues/1217) * **deps:** Bump goreleaser/goreleaser-action from 3.1.0 to 4.1.0 ([#414](#414)) ([e963ba1](e963ba1)), closes [goreleaser/goreleaser-action#382](goreleaser/goreleaser-action#382) [goreleaser/goreleaser-action#366](goreleaser/goreleaser-action#366) [goreleaser/goreleaser-action#379](goreleaser/goreleaser-action#379) [goreleaser/goreleaser-action#383](goreleaser/goreleaser-action#383) [goreleaser/goreleaser-action#366](goreleaser/goreleaser-action#366) [goreleaser/goreleaser-action#379](goreleaser/goreleaser-action#379) [goreleaser/goreleaser-action#370](goreleaser/goreleaser-action#370) [#374](#374) [#372](#372) [#373](#373) [#383](#383) [#366](#366) [#382](#382) [#370](#370) * **deps:** Bump k8s.io/api from 0.25.4 to 0.26.0 ([#407](#407)) ([d13bf5e](d13bf5e)), closes [#111023](https://github.com/estahn/k8s-image-swapper/issues/111023) [#113375](https://github.com/estahn/k8s-image-swapper/issues/113375) [#113186](https://github.com/estahn/k8s-image-swapper/issues/113186) * **deps:** Bump k8s.io/client-go from 0.25.4 to 0.26.0 ([#410](#410)) ([bcc56b5](bcc56b5)), closes [#113797](https://github.com/estahn/k8s-image-swapper/issues/113797) [#111023](https://github.com/estahn/k8s-image-swapper/issues/111023) [#113826](https://github.com/estahn/k8s-image-swapper/issues/113826) [#113375](https://github.com/estahn/k8s-image-swapper/issues/113375)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://github.com/actions/checkout) | action | major | `v3` -> `v4` | | [crazy-max/ghaction-import-gpg](https://github.com/crazy-max/ghaction-import-gpg) | action | major | `v5` -> `v6` | | [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) | action | major | `v3.2.0` -> `v5.0.0` | | [magefile/mage-action](https://github.com/magefile/mage-action) | action | major | `v2` -> `v3` | | [magnetikonline/action-golang-cache](https://github.com/magnetikonline/action-golang-cache) | action | major | `v3` -> `v4` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v400) [Compare Source](https://github.com/actions/checkout/compare/v3...v4) - [Support fetching without the --progress option](https://github.com/actions/checkout/pull/1067) - [Update to node20](https://github.com/actions/checkout/pull/1436) </details> <details> <summary>crazy-max/ghaction-import-gpg (crazy-max/ghaction-import-gpg)</summary> ### [`v6`](https://github.com/crazy-max/ghaction-import-gpg/compare/v5...v6) [Compare Source](https://github.com/crazy-max/ghaction-import-gpg/compare/v5...v6) </details> <details> <summary>goreleaser/goreleaser-action (goreleaser/goreleaser-action)</summary> ### [`v5.0.0`](https://github.com/goreleaser/goreleaser-action/releases/tag/v5.0.0) [Compare Source](https://github.com/goreleaser/goreleaser-action/compare/v4.6.0...v5.0.0) #### What's Changed - feat: node 20 as default runtime (requires [Actions Runner v2.308.0](https://github.com/actions/runner/releases/tag/v2.308.0) or later) by [@​crazy-max](https://github.com/crazy-max) in [goreleaser/goreleaser-action#432 - chore(deps): bump [@​actions/core](https://github.com/actions/core) from 1.10.0 to 1.10.1 in [goreleaser/goreleaser-action#434 **Full Changelog**: goreleaser/goreleaser-action@v4.6.0...v5.0.0 ### [`v4.6.0`](https://github.com/goreleaser/goreleaser-action/releases/tag/v4.6.0) [Compare Source](https://github.com/goreleaser/goreleaser-action/compare/v4.5.0...v4.6.0) Reverts the change to `node20` runtime. **Full Changelog**: goreleaser/goreleaser-action@v4.5.0...v4.6.0 ### [`v4.5.0`](https://github.com/goreleaser/goreleaser-action/releases/tag/v4.5.0) [Compare Source](https://github.com/goreleaser/goreleaser-action/compare/v4.4.0...v4.5.0) #### What's Changed - chore(deps): bump word-wrap from 1.2.3 to 1.2.5 by [@​dependabot](https://github.com/dependabot) in [goreleaser/goreleaser-action#427 - feat: bump to use node20 runtime, actions/checkout to v4 by [@​kbdharun](https://github.com/kbdharun) in [goreleaser/goreleaser-action#430 #### New Contributors - [@​kbdharun](https://github.com/kbdharun) made their first contribution in [goreleaser/goreleaser-action#430 **Full Changelog**: goreleaser/goreleaser-action@v4.4.0...v4.5.0 ### [`v4.4.0`](https://github.com/goreleaser/goreleaser-action/releases/tag/v4.4.0) [Compare Source](https://github.com/goreleaser/goreleaser-action/compare/v4.3.0...v4.4.0) #### What's Changed - chore(deps): bump semver from 7.5.0 to 7.5.1 by [@​dependabot](https://github.com/dependabot) in [goreleaser/goreleaser-action#417 - feat: support oss nightlies by [@​caarlos0](https://github.com/caarlos0) in [goreleaser/goreleaser-action#424 **Full Changelog**: goreleaser/goreleaser-action@v4.3.0...v4.4.0 ### [`v4.3.0`](https://github.com/goreleaser/goreleaser-action/releases/tag/v4.3.0) [Compare Source](https://github.com/goreleaser/goreleaser-action/compare/v4.2.0...v4.3.0) #### What's Changed - Update in command examples by [@​arnaduga](https://github.com/arnaduga) in [goreleaser/goreleaser-action#393 - chore(deps): bump yargs from 17.6.2 to 17.7.0 by [@​dependabot](https://github.com/dependabot) in [goreleaser/goreleaser-action#395 - Improve documentation for use of `GITHUB_TOKEN` by [@​jamietanna](https://github.com/jamietanna) in [goreleaser/goreleaser-action#399 - chore(deps): bump actions/setup-go from 3 to 4 by [@​dependabot](https://github.com/dependabot) in [goreleaser/goreleaser-action#403 - chore(deps): bump docker/bake-action from 2 to 3 by [@​dependabot](https://github.com/dependabot) in [goreleaser/goreleaser-action#408 - chore(deps): bump semver from 7.3.8 to 7.5.0 by [@​dependabot](https://github.com/dependabot) in [goreleaser/goreleaser-action#407 - Bump setup-go action version to v4 in README by [@​kishaningithub](https://github.com/kishaningithub) in [goreleaser/goreleaser-action#411 - ci: split test and validate workflow by [@​crazy-max](https://github.com/crazy-max) in [goreleaser/goreleaser-action#413 - chore: update yarn to 3.5.1 by [@​crazy-max](https://github.com/crazy-max) in [goreleaser/goreleaser-action#412 - chore(deps): bump yargs from 17.7.1 to 17.7.2 by [@​dependabot](https://github.com/dependabot) in [goreleaser/goreleaser-action#410 - feat: support nightly by [@​caarlos0](https://github.com/caarlos0) in [goreleaser/goreleaser-action#419 #### New Contributors - [@​arnaduga](https://github.com/arnaduga) made their first contribution in [goreleaser/goreleaser-action#393 - [@​jamietanna](https://github.com/jamietanna) made their first contribution in [goreleaser/goreleaser-action#399 - [@​kishaningithub](https://github.com/kishaningithub) made their first contribution in [goreleaser/goreleaser-action#411 **Full Changelog**: goreleaser/goreleaser-action@v4.2.0...v4.3.0 ### [`v4.2.0`](https://github.com/goreleaser/goreleaser-action/releases/tag/v4.2.0) [Compare Source](https://github.com/goreleaser/goreleaser-action/compare/v4.1.1...v4.2.0) ##### What's Changed - fix: don't depend on the GitHub API to check release by [@​crazy-max](https://github.com/crazy-max) in [goreleaser/goreleaser-action#391 **Full Changelog**: goreleaser/goreleaser-action@v4.1.1...v4.2.0 ### [`v4.1.1`](https://github.com/goreleaser/goreleaser-action/releases/tag/v4.1.1) [Compare Source](https://github.com/goreleaser/goreleaser-action/compare/v4.1.0...v4.1.1) ##### What's Changed - Update Readme to reference `goreleaser/goreleaser-action@v4` by [@​felladrin](https://github.com/felladrin) in [goreleaser/goreleaser-action#384 - docs: fix README badge by [@​dirien](https://github.com/dirien) in [goreleaser/goreleaser-action#386 - chore(deps): bump json5 from 2.2.0 to 2.2.3 by [@​dependabot](https://github.com/dependabot) in [goreleaser/goreleaser-action#388 - fix: use [@​action/github](https://github.com/action/github) by [@​caarlos0](https://github.com/caarlos0) and [@​crazy-max](https://github.com/crazy-max) in [goreleaser/goreleaser-action#390 ##### New Contributors - [@​felladrin](https://github.com/felladrin) made their first contribution in [goreleaser/goreleaser-action#384 - [@​dirien](https://github.com/dirien) made their first contribution in [goreleaser/goreleaser-action#386 **Full Changelog**: goreleaser/goreleaser-action@v4.1.0...v4.1.1 ### [`v4.1.0`](https://github.com/goreleaser/goreleaser-action/releases/tag/v4.1.0) [Compare Source](https://github.com/goreleaser/goreleaser-action/compare/v4.0.0...v4.1.0) ##### What's Changed - feat!: remove auto-snapshot on dirty tag by [@​caarlos0](https://github.com/caarlos0) in [goreleaser/goreleaser-action#382 - docs: add example when using workdir along with upload-artifact by [@​zdtsw](https://github.com/zdtsw) in [goreleaser/goreleaser-action#366 - Fix Self-Hosted Windows Error: Expand-Archive by [@​flarco](https://github.com/flarco) in [goreleaser/goreleaser-action#379 - chore(deps): bump minimatch from 3.0.4 to 3.1.2 by [@​dependabot](https://github.com/dependabot) in [goreleaser/goreleaser-action#383 ##### Migrating from v3 If you need the auto-snapshot feature, take a look at [this example repository](https://github.com/caarlos0/goreleaser-action-v4-auto-snapshot-example): it's a minimal working example with all you need. ##### New Contributors - [@​zdtsw](https://github.com/zdtsw) made their first contribution in [goreleaser/goreleaser-action#366 - [@​flarco](https://github.com/flarco) made their first contribution in [goreleaser/goreleaser-action#379 **Full Changelog**: goreleaser/goreleaser-action@v4...v4.1.0 ### [`v4.0.0`](https://github.com/goreleaser/goreleaser-action/releases/tag/v4.0.0) [Compare Source](https://github.com/goreleaser/goreleaser-action/compare/v3.2.0...v4.0.0) ##### What's Changed - fix: do not override GORELEASER_CURRENT_TAG by [@​caarlos0](https://github.com/caarlos0) in [goreleaser/goreleaser-action#370 ##### Migrating from v3 If you need the auto-snapshot feature, take a look at [this example repository](https://github.com/caarlos0/goreleaser-action-v4-auto-snapshot-example): it's a minimal working example with all you need. **Full Changelog**: goreleaser/goreleaser-action@v3...v4.0.0 </details> <details> <summary>magefile/mage-action (magefile/mage-action)</summary> ### [`v3`](https://github.com/magefile/mage-action/compare/v2...v3) [Compare Source](https://github.com/magefile/mage-action/compare/v2...v3) </details> <details> <summary>magnetikonline/action-golang-cache (magnetikonline/action-golang-cache)</summary> ### [`v4`](https://github.com/magnetikonline/action-golang-cache/releases/tag/v4) [Compare Source](https://github.com/magnetikonline/action-golang-cache/compare/v3...v4) - Provide action outputs of `build-cache-path`, `module-cache-path` and `cache-key`. - Bump `actions/setup-go@v4` - Some `README.md` cleanups. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/DelineaXPM/terraform-provider-dsv). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
we shouldn't really do this.. as when using monorepo.tag_prefix it'll set the wrong tag to goreleaser.
that said, I'm not really sure about the auto-snapshot thingy too... seems easy enough to check on the workflow if the current commit is a tag or not, and act accordingly, no?