Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support running GoReleaser on a Go project inside a subdirectory #45

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

boazy
Copy link
Contributor

@boazy boazy commented Dec 2, 2019

Sometimes you might be running a repository which needs to have the go projected rooted in a subdirectory (e.g. a mono-repo with code in multiple languages).

In this case, you can't just use args to specify a configuration file inside the sub-directory, since Go will still search for the module definition (or the vendor/ directory) in the current working directory from which GoReleaser is run - which happens to be the repository's root directory.

This PR simply adds a new input (subdir) that allows you to specify a subdirectory under the repository root.

@boazy boazy changed the title Support running GoReleaser on a Go project inside a subdirectory feat: Support running GoReleaser on a Go project inside a subdirectory Dec 2, 2019
@crazy-max
Copy link
Member

@boazy Thanks for your contrib. I think it would be better to have a workdir input with a default value to . instead. Also, can you update the relevant documentation (README)?

@boazy boazy force-pushed the master branch 2 times, most recently from 661deb4 to 985f48d Compare December 2, 2019 08:43
@boazy
Copy link
Contributor Author

boazy commented Dec 2, 2019

@crazy-max Done!

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boazy One more thing and we are good

action.yml Outdated Show resolved Hide resolved
@crazy-max
Copy link
Member

@boazy LGTM, thanks for your contrib!

@crazy-max crazy-max merged commit 16077aa into goreleaser:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants