Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changelog.skip template-able #3828

Closed
2 tasks done
joelanford opened this issue Mar 3, 2023 · 1 comment · Fixed by #3830
Closed
2 tasks done

Make changelog.skip template-able #3828

joelanford opened this issue Mar 3, 2023 · 1 comment · Fixed by #3830
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@joelanford
Copy link

joelanford commented Mar 3, 2023

Is your feature request related to a problem? Please describe.

I have a goreleaser setup that pushes docker images and manifest lists on tag builds AND on builds of certain branches (e.g. our main branch). To do this successfully for branches, I need to disable the changelog and release configurations. But I still want to publish docker images and docker manifests.

Describe the solution you'd like

I see that as of #3710, I can now template release.disable to use something like {{ eq .Tag ""} or {{ .Env.DISABLE }}.

I'd like to make changelog.skip template-able in the exact same way that release.disable is so that I can use the same template to enable/disable them together.

Describe alternatives you've considered

Right now my workaround is to set release.disable and changelog.skip to true in my goreleaser config. But then during CI, I modify the goreleaser config file just before the goreleaser release call to set release.disable and changelog.skip to false when its a tag build.

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@joelanford joelanford added enhancement New feature or request triage Issue pending triage by one of the maintainers labels Mar 3, 2023
@joelanford
Copy link
Author

Seems like this discussion is related: #1733 (comment)

Though it also seems that suggestion requires a much larger change.

@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label Mar 3, 2023
caarlos0 added a commit that referenced this issue Mar 3, 2023
caarlos0 added a commit that referenced this issue Mar 3, 2023
@caarlos0 caarlos0 added this to the v1.16.0 milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants