Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compression option with xz support for deb #363

Merged
merged 6 commits into from
Sep 4, 2021

Conversation

erikgeiser
Copy link
Member

This PR adds a compression option for deb files. Currently the following values are supported:

  • gzip (default)
  • xz (future default)
  • none (no compression)

I think the best way to move forward is to keep gzip as default for now and wait for feedback from the users that use xz. If everything works great (and if xz build times are acceptable), we should make xz the default in a following release.

Closes #361.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 2, 2021
@vercel
Copy link

vercel bot commented Sep 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/EJ4dyAm4si4HjDbW5rArxL5qyz9P
✅ Preview: https://nfpm-git-fork-erikgeiser-xzcompression-goreleaser.vercel.app

@vercel vercel bot temporarily deployed to Preview September 2, 2021 18:57 Inactive
@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #363 (2c18ac9) into master (995311c) will increase coverage by 0.13%.
The diff coverage is 65.21%.

❗ Current head 2c18ac9 differs from pull request most recent head 0d2d305. Consider uploading reports for the commit 0d2d305 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
+ Coverage   64.89%   65.03%   +0.13%     
==========================================
  Files          14       14              
  Lines        1262     1284      +22     
==========================================
+ Hits          819      835      +16     
- Misses        309      313       +4     
- Partials      134      136       +2     
Impacted Files Coverage Δ
nfpm.go 86.20% <ø> (ø)
deb/deb.go 66.56% <65.21%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995311c...0d2d305. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview September 2, 2021 21:05 Inactive
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpick, lgtm otherwise

great work, thanks!

deb/deb.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2021
@vercel vercel bot temporarily deployed to Preview September 3, 2021 14:26 Inactive
@erikgeiser
Copy link
Member Author

I've prepared another PR that changes the default compression algorithm and the corresponding documentation. I will publish it as soon as this PR is merged, so you can easily update the default in another release if everything goes well.

@vercel vercel bot temporarily deployed to Preview September 4, 2021 13:24 Inactive
@caarlos0 caarlos0 merged commit 2a331c5 into goreleaser:master Sep 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XZ-compressed Debian packages
2 participants