-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: compression option with xz support for deb #363
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/nfpm/EJ4dyAm4si4HjDbW5rArxL5qyz9P |
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
+ Coverage 64.89% 65.03% +0.13%
==========================================
Files 14 14
Lines 1262 1284 +22
==========================================
+ Hits 819 835 +16
- Misses 309 313 +4
- Partials 134 136 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpick, lgtm otherwise
great work, thanks!
I've prepared another PR that changes the default compression algorithm and the corresponding documentation. I will publish it as soon as this PR is merged, so you can easily update the default in another release if everything goes well. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR adds a
compression
option fordeb
files. Currently the following values are supported:gzip
(default)xz
(future default)none
(no compression)I think the best way to move forward is to keep
gzip
as default for now and wait for feedback from the users that usexz
. If everything works great (and ifxz
build times are acceptable), we should makexz
the default in a following release.Closes #361.