fix: Prevent duplicate folders from being created. #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## main #411 +/- ##
==========================================
+ Coverage 66.19% 66.68% +0.48%
==========================================
Files 15 15
Lines 1855 1876 +21
==========================================
+ Hits 1228 1251 +23
+ Misses 488 487 -1
+ Partials 139 138 -1
Continue to review full report at Codecov.
|
|
good catch, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a package can contain duplicate folders depending on the way a user specified a dir-type content destination (folder name). This PR fixes that by keeping track of created folders in the already existing
createdmap with a consistent naming convention. It also adds related tests.Another bug that's also fixed by this PR is that auto-created folders did not have a owner username and group name.