Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand dependencies' version #454

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Expand dependencies' version #454

merged 1 commit into from
Feb 9, 2022

Conversation

Felixoid
Copy link
Contributor

@Felixoid Felixoid commented Feb 9, 2022

Now the version is expanded in version, but in case, when many packages are built and depend on near one with the same version it doesn't work.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 9, 2022
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2022
@Felixoid
Copy link
Contributor Author

Felixoid commented Feb 9, 2022

Here's an example of a problem https://github.com/ClickHouse/ClickHouse/blob/8d475e8c135c311b5a81e059b680eeee17b3bb5c/packages/clickhouse-client.yaml#L29

The packages are built together, but VERSION is expanded only partially.

djgilcrease
djgilcrease approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 9, 2022 •
edited
Loading

Codecov Report

Merging #454 (1f3bf07) into main (aba336a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   65.86%   65.89%   +0.03%     
==========================================
  Files          16       16              
  Lines        1901     1903       +2     
==========================================
+ Hits         1252     1254       +2     
  Misses        510      510              
  Partials      139      139
Impacted Files Coverage Δ
nfpm.go 86.43% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba336a...1f3bf07. Read the comment docs.

@Felixoid Felixoid changed the title Expanc dependencies' version Expand dependencies' version Feb 9, 2022
@Felixoid
Copy link
Contributor Author

Felixoid commented Feb 9, 2022

is docs / htmltest test something that I should care about?

@caarlos0
Copy link
Member

caarlos0 commented Feb 9, 2022

is docs / htmltest test something that I should care about?

no idea why it started to fail recently, will investigate eventually

caarlos0
caarlos0 approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@caarlos0 caarlos0 merged commit 1000d10 into goreleaser:main Feb 9, 2022
@github-actions github-actions bot added this to the 2.12.0 milestone Feb 9, 2022
@Felixoid Felixoid deleted the dep-envs branch February 10, 2022 00:08
@Felixoid
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djgilcrease djgilcrease djgilcrease approved these changes

@caarlos0 caarlos0 caarlos0 approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Felixoid @caarlos0 @djgilcrease