-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update rpmpack and change default compressor to gzip:-1 (a default level) instead of gzip:9 #458
Conversation
Codecov Report
@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 65.93% 65.98% +0.05%
==========================================
Files 16 16
Lines 1905 1908 +3
==========================================
+ Hits 1256 1259 +3
Misses 510 510
Partials 139 139
Continue to review full report at Codecov.
|
I think we can leave the default as |
The difference between 5 and 9 levels in speed is huge, 1.5 vs 7.5 minutes, and only 5% in space, difficult to recall exact numbers, something like 1015MB vs 970MB. I'd say, 9 is rather worthless. 9 is defined by rpmpack, and for deb and apk |
well, that depends entirely in the use case of the package, some people may need those 5% shrink for some reason.
then yes, this makes sense. |
thanks! |
Thank you for reviewing! BTW, the bot just added 2.12.0 milestone. Looks like something wrong since 2.13 is released. |
thanks, fixed it @Felixoid |
The default compression level for rpm is 9. https://github.com/google/rpmpack/blob/master/rpm.go#L165
Because of it, rpm packaging is significantly slower than deb, almost 5 times worse.
Here I bump the dependencies, add tests and change default level to -1