Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expand environment variables in maintainer #463

Merged
merged 1 commit into from
Mar 18, 2022
Merged

feat: expand environment variables in maintainer #463

merged 1 commit into from
Mar 18, 2022

Conversation

scop
Copy link
Contributor

@scop scop commented Feb 21, 2022

No description provided.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022 •
edited
Loading

Codecov Report

Merging #463 (285912c) into main (b684867) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
+ Coverage   65.98%   66.00%   +0.01%     
==========================================
  Files          16       16              
  Lines        1908     1909       +1     
==========================================
+ Hits         1259     1260       +1     
  Misses        510      510              
  Partials      139      139
Impacted Files Coverage Δ
nfpm.go 86.50% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b684867...285912c. Read the comment docs.

@Felixoid
Copy link
Contributor

Felixoid commented Mar 14, 2022 •
edited
Loading

I'd like to encourage this PR. Although we use static author, GIT parameters as author look very nice!

djgilcrease
djgilcrease approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd to me you would want your maintainer to potentially change with every commit, but other than that it looks fine to me.

@caarlos0 caarlos0 merged commit 97486f1 into goreleaser:main Mar 18, 2022
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 18, 2022
@caarlos0
Copy link
Member

Thanks!

@scop scop deleted the feat/maintainer-expand-env branch March 20, 2022 10:57
@caarlos0 caarlos0 modified the milestones: 2.13.0, 2.15.0 Mar 25, 2022
@caarlos0 caarlos0 added the enhancement New feature or request label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djgilcrease djgilcrease djgilcrease approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@scop @Felixoid @caarlos0 @djgilcrease