Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apk): conventional name template #794

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fix(apk): conventional name template #794

merged 2 commits into from
Mar 11, 2024

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Mar 5, 2024

closes #793

closes #793

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the bug Something isn't working label Mar 5, 2024
@caarlos0 caarlos0 self-assigned this Mar 5, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 5, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d2564b
Status: ✅  Deploy successful!
Preview URL: https://bee976a2.nfpm.pages.dev
Branch Preview URL: https://apk.nfpm.pages.dev

View logs

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.23%. Comparing base (f271181) to head (0d2564b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
+ Coverage   72.07%   72.23%   +0.16%     
==========================================
  Files          20       20              
  Lines        2206     2219      +13     
==========================================
+ Hits         1590     1603      +13     
  Misses        435      435              
  Partials      181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apk/apk.go Show resolved Hide resolved
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 merged commit 29c8a21 into main Mar 11, 2024
20 of 41 checks passed
@caarlos0 caarlos0 deleted the apk branch March 11, 2024 12:05
@github-actions github-actions bot added this to the 2.36.0 milestone Mar 11, 2024
caarlos0 added a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APK: setting release creates invalid package version
2 participants