Merge pull request #21 from walterdolce/feature/throw-exception-if-re…

…quested-state-is-missing

Throw exception when asked for missing state

src/ScenarioState.php

@@ -11,6 +11,8 @@
 
 namespace Gorghoa\ScenarioStateBehatExtension;
 
+use Gorghoa\ScenarioStateBehatExtension\ScenarioState\Exception\MissingStateException;
+
 /**
  * @author Rodrigue Villetard <rodrigue.villetard@gmail.com>
  */
@@ -26,14 +28,18 @@ class ScenarioState implements ScenarioStateInterface
      */
     public function hasStateFragment($key)
     {
-        return isset($this->store[$key]);
+        return array_key_exists($key, $this->store);
     }
 
     /**
      * {@inheritdoc}
      */
     public function getStateFragment($key)
     {
+        if (!$this->hasStateFragment($key)) {
+            throw new MissingStateException("Missing {$key} state fragment was requested from store.");
+        }
+
         return $this->store[$key];
     }
 

src/ScenarioState/Exception/MissingStateException.php

@@ -0,0 +1,17 @@
+<?php
+/*
+ * This file is part of the ScenarioStateBehatExtension project.
+ *
+ * (c) Rodrigue Villetard <rodrigue.villetard@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace Gorghoa\ScenarioStateBehatExtension\ScenarioState\Exception;
+
+/**
+ * @author Walter Dolce <walterdolce@gmail.com>
+ */
+class MissingStateException extends \LogicException
+{
+}

src/ScenarioStateInterface.php

@@ -10,6 +10,7 @@
  */
 
 namespace Gorghoa\ScenarioStateBehatExtension;
+use Gorghoa\ScenarioStateBehatExtension\ScenarioState\Exception\MissingStateException;
 
 /**
  * @author Rodrigue Villetard <rodrigue.villetard@gmail.com>
@@ -24,7 +25,7 @@ public function provideStateFragment($key, $value);
 
     /**
      * @param string $key
-     *
+     * @throws MissingStateException
      * @return mixed
      */
     public function getStateFragment($key);

tests/ScenarioStateTest.php

@@ -0,0 +1,24 @@
+<?php
+/*
+ * This file is part of the ScenarioStateBehatExtension project.
+ *
+ * (c) Rodrigue Villetard <rodrigue.villetard@gmail.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+namespace Gorghoa\ScenarioStateBehatExtension;
+
+use Gorghoa\ScenarioStateBehatExtension\ScenarioState\Exception\MissingStateException;
+
+/**
+ * @author Walter Dolce <walterdolce@gmail.com>
+ */
+class ScenarioStateTest extends \PHPUnit_Framework_TestCase
+{
+    public function testItThrowsExceptionWhenStateIsMissing()
+    {
+        $this->setExpectedException(MissingStateException::class);
+        (new ScenarioState())->getStateFragment('not_existing_state');
+    }
+}