[RFR] Inject store arguments in Behat hooks non step methods #24
Conversation
src/ScenarioStateCall.php
Outdated
| $environment; | ||
| $hook; | ||
| $arguments; | ||
| $errorReportingLevel; |
There was a problem hiding this comment.
I don’t quite see the point of those expressions 🤔
There was a problem hiding this comment.
Hey, it's still WIP ;)
vincentchalamon
changed the title
|
Unit tests in progress… |
| */ | ||
| public function dispatchScopeHooks(HookScope $scope) | ||
| { | ||
| $results = array(); |
| continue; | ||
| } | ||
|
|
||
| $paramsKeys = array_map(function($element) { |
There was a problem hiding this comment.
What about foreach vs array_map()?
| return $setup; | ||
| } | ||
|
|
||
| $hookCallResults = $this->dispatcher->dispatchScopeHooks(new BeforeScenarioScope($env, $feature, $scenario)); |
| return $teardown; | ||
| } | ||
|
|
||
| $hookCallResults = $this->dispatcher->dispatchScopeHooks(new AfterScenarioScope($env, $feature, $scenario, $result)); |
|
Scrutinizer patches are wrong: http://www.php-fig.org/psr/psr-2/#closures |
|
@meyerbaptiste, ok for you? |
|
@Gregcop1, If you have some time to spend, could you verify that the PR fixes your use case? (If not, just trust @vincentchalamon’s work and everything will be fine I’m sure) |
|
Note. I’m okay with the small BC breaks due to namespace reorganization (the I suggest to ship it to minor version anymay, even if it conflicts with semver. I expect no one will feel the pain since it’s deeply internal subject and the user base is still small ;) |
Fix #23