Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

php version >=7.0 #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

php version >=7.0 #39

wants to merge 1 commit into from

Conversation

gorghoa
Copy link
Owner

@gorghoa gorghoa commented Sep 25, 2020

Set minimum php version to 7.0.

Builds on php 5 are failing and I don’t see the point to take time to maintain them.

@gorghoa
Copy link
Owner Author

gorghoa commented Sep 25, 2020

ref #38

@vincentchalamon
Copy link
Collaborator

LGTM

@gorghoa gorghoa mentioned this pull request Sep 25, 2020
Merged
@vincentchalamon vincentchalamon mentioned this pull request Oct 7, 2020
Merged
vincentchalamon
vincentchalamon suggested changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need rebase + update code according to PHP7 optimizations (typehint, etc.)

@gorghoa
Copy link
Owner Author

gorghoa commented Oct 7, 2020 •
edited
Loading

So, which php 7 lowest version shall we support?

Regarding https://www.php.net/supported-versions.php:

image

I would personally be comfortable to require at least php 7.2 (eventually php 7.3 since php 7.2 will stop being supported within a month)

@vincentchalamon
Copy link
Collaborator

I would be personally comfortable to require at least php 7.2 (eventually php 7.3 since php 7.2 will stop being supported within a month)

Agree with 7.2 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vincentchalamon vincentchalamon vincentchalamon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gorghoa @vincentchalamon