Skip to content
This repository has been archived by the owner on Nov 15, 2017. It is now read-only.

Google Hangouts app: a case of sub_frame created without a root frame #91

Closed
gorhill opened this issue Dec 16, 2013 · 5 comments
Closed

Comments

@gorhill
Copy link
Owner

gorhill commented Dec 16, 2013

HTTPSB always expects that a tab is always bound to a root frame. However, it appears that when user install the Google Hangouts app, this one will create a tab with a sub_frame in it, with no root frame.

Have to find a way to take care of that sort of unexpected case.

@gorhill
Copy link
Owner Author

gorhill commented Dec 16, 2013

Apparently I will have to implement a heuristic.

If a sub_frame is requested while no page stats store can be found for the tab id, this is an app. Create a page stats store for this app, than assign true to this pageStats.ignore -- because of HTTPSB's policy to not interfere with apps or extensions.

gorhill added a commit that referenced this issue Dec 17, 2013
@gorhill gorhill closed this as completed Dec 17, 2013
@attila-lendvai
Copy link

what's the situation these days, should hangouts work with httpsb?

i can only make it work by completely disabling httpsb. tried to look at the global settings, but couldn't see anything blocked that i could allow for hangouts to work.

and pointers that i should read? this is the single match when searching for httpsb + hangouts.

@gorhill
Copy link
Owner Author

gorhill commented Mar 10, 2014

I will look into this. Just to be sure, Hangout is the extension one installs from the store, right?

Note that with the latest version of chromium (and derivatives probably), I have noted more requests which are improperly marked as behind-the-scene by the browser, so often you may need to go to the behind the scene matrix and enable from there whatever requests is blocked.

@gorhill gorhill reopened this Mar 10, 2014
@attila-lendvai
Copy link

yes, i meant google hangout as installed from the extension store (and of course i also have the linux dpkg's installed that are needed by the chrome plugin).

i'm using chromium Version 32.0.1700.123 Debian 7.4 (248368) on debian x64.

i've looked at the chromium-behind-the-scene but there pretty much everything was green except a couple of obvious entries (google analytics and csi.gstatic.com).

@gorhill
Copy link
Owner Author

gorhill commented Mar 10, 2014

Ok, found the problem. Looking into a fix, hopefully for today.

Thanks for having reported the issue, from what I can tell this has been broken since a while now.

For the record, it's the sandbox directive added to the sub_frame used by Hangout which disables javascript for the gadget. This code is old and it needs revision to bring it up to date.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants