really fix #2776

gorhill · Jul 9, 2017 · 9701a51 · 9701a51
1 parent 974194a
commit 9701a51
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/js/tab.js b/src/js/tab.js
@@ -704,9 +704,6 @@ vAPI.tabs.onPopupUpdated = (function() {
     };
 
     return function(targetTabId, openerTabId) {
-        // https://github.com/gorhill/uBlock/issues/2776
-        logData = undefined;
-
         // Opener details.
         var tabContext = µb.tabContextManager.lookup(openerTabId);
         if ( tabContext === null ) { return; }
@@ -752,16 +749,18 @@ vAPI.tabs.onPopupUpdated = (function() {
         }
 
         // Log only for when there was a hit against an actual filter (allow or block).
+        // https://github.com/gorhill/uBlock/issues/2776
         if ( µb.logger.isEnabled() ) {
             µb.logger.writeOne(
                 popupType === 'popup' ? openerTabId : targetTabId,
                 'net',
-                logData,
+                result !== 0 ? logData : undefined,
                 popupType,
                 popupType === 'popup' ? targetURL : openerURL,
                 µb.URI.hostnameFromURI(context.rootURL),
                 µb.URI.hostnameFromURI(context.rootURL)
             );
+            logData = undefined;
         }
 
         // Not blocked