Menu has too much space on the top and bottom

[streetwolf]

Icon menu has extra space on the top and bottom as seen where I place arrows on the screenshot. Mozilla fixed the menu being too wide but evidently didn't fix this problem. I thought I saw a patch that addressed this on Bugzilla but I could be wrong or it didn't work.

Running latest Fx55 Nightly. Running uBlock Origin v1.12.5rc2. Windows 10 64 bit CU with all cumulative updates.

Filter lists not applicable in this case.

[streetwolf]

The extra space is produced when you turn on Photon mode via 'browser.photon.structure.enabled = true' in prefs.js. Normal mode it looks OK. Photon will be upon us soon so it might be proactive to get this fixed soon.

[gorhill]

Shouldn't this be filed in Firefox issue tracker?

uBO embed its frame into the Firefox's-provided panel, and that panel has a padding style causing the issue (line 339 in panelUI.css):

/* START photonpanelview adjustments */

#appMenu-popup > .panel-arrowcontainer > .panel-arrowcontent {
  padding: 0;
  border-radius: 0;
}

photonpanelmultiview panelview {
  background: var(--arrowpanel-background);
  padding: 6px 0;
}

When commenting out the padding style above (the 6px one), it renders fine. The padding style above is in addition to the padding style seen in one of the ancestor element (line 328 in panelUI.css):

.cui-widget-panel > .panel-arrowcontainer > .panel-arrowcontent {
  padding: 4px 0;
}

Meaning the resulting padding is 10 pixels with Photon. I doubt this was meant to be this much. One of the two styles probably needs to be revised.

[streetwolf]

Ray… Are you saying a bug report should be opened on this issue in Bugzilla? I can do it but I thought that as the author of uBO it would make more sense for you to open up a bug report as you know what the problem is. Also, I see you took the link to the WE version away. No doubt from the recent changes Mozilla made. Are you re-writing uBO for WE or waiting until WE becomes more stable?

…

____ Gary From: Raymond Hill<mailto:notifications@github.com> Sent: Saturday, June 10, 2017 4:44 PM To: gorhill/uBlock<mailto:uBlock@noreply.github.com> Cc: Gary<mailto:garyshap@outlook.com>; Author<mailto:author@noreply.github.com> Subject: Re: [gorhill/uBlock] Menu has too much space on the top and bottom (#2696) Shouldn't this be filed in Firefox issue tracker? uBO embed its frame into the Firefox's-provided panel, and it has a padding style causing the issue (line 339 in panelUI.css): /* START photonpanelview adjustments */ #appMenu-popup > .panel-arrowcontainer > .panel-arrowcontent { padding: 0; border-radius: 0; } photonpanelmultiview panelview { background: var(--arrowpanel-background); padding: 6px 0; } When commenting out the padding style above, it renders fine. The padding style above is in addition to the padding style seen in one of the ancestor (line 328 in panelUI.css): .cui-widget-panel > .panel-arrowcontainer > .panel-arrowcontent { padding: 4px 0; } Meaning the resulting padding is 10 pixels. I doubt this was meant to be this much. One of the two styles probably needs to be revised. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2696 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAZErydmgrcwr3rZPZ9QgunvOQfmc3mqks5sCwAOgaJpZM4N2Me2>.

[gorhill]

Are you re-writing uBO for WE or waiting until WE becomes more stable?

See #2684 (comment). uBO does not need to be re-written, the Chromium version is the webext version, with very minor changes.

[gorhill]

Looking a bit more into this, I could set the padding myself, but that seems a odd thing to do for uBO, as it would force uBO to make assumption about and deal with stuff which are not its responsibility. It's unclear to me what was the intended behavior here by whoever is working on Photon.

[gorhill]

I just forced the style in uBO, faster for me to change the chrome style than to report an issue on bugzilla. Tested with Pale Moon, Sea Monkey, Firefox 53, Nightly with and without Photon, with legacy and webext.

This means that legacy without Photon won't have padding anymore at the top and bottom like it used to be. Never mind, not true, it's the webext version of uBO on non-Photon Firefox which has no padding.