Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user style sheets on Chromium #3588

Closed
mjethani opened this issue Mar 9, 2018 · 5 comments
Closed

Use user style sheets on Chromium #3588

mjethani opened this issue Mar 9, 2018 · 5 comments

Comments

@mjethani
Copy link
Contributor

mjethani commented Mar 9, 2018

Chromium now supports user style sheets via the cssOrigin option to tabs.insertCSS. Adblock Plus has already implemented changes to use the feature when it's available. uBlock Origin should do the same.

For reference, see Chromium bug #632009.

@gorhill
Copy link
Owner

gorhill commented Apr 12, 2018

Unfortunately, chrome.tabs.removeCSS is not implemented and this breaks some features in uBO, notably the toggling of cosmetic filtering (not a deal breaker, it just affects the real-time part of the feature), but more importantly this breaks the DOM inspector.

@uBlock-user
Copy link
Contributor

It's a WIP apparently - https://bugs.chromium.org/p/chromium/issues/detail?id=608854

@gwarser
Copy link
Contributor

gwarser commented Oct 1, 2020

@uBlock-user
Copy link
Contributor

Yes, in Canary.

@gorhill
Copy link
Owner

gorhill commented Oct 1, 2020

I'm puzzled as to what motivated them to implement this now after all that time ignoring the original pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants