Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Collapse placeholders for blacklisted hostnames #335

Closed
vdcbb opened this issue Aug 28, 2015 · 0 comments
Closed

Collapse placeholders for blacklisted hostnames #335

vdcbb opened this issue Aug 28, 2015 · 0 comments
Labels

Comments

@vdcbb
Copy link

vdcbb commented Aug 28, 2015

There is a setting entry to "Collapse placeholder of blocked elements." But there is a difference between "blocked elements" and "blacklisted hostnames."

Blacklisting a hostname means that the user wants no interaction with that host. But a blocked element is different. For example, a user may want 3rd-party frames from Youtube blocked (but not collapsed). So user will keep Youtube as a blocked element (on 3rd party sites) so that placeholders display, allowing user to open the Frame in a new tab. Yet user may want no interaction with addthis.com ever, and user does not want to see placeholders for addthis.com frames on any pages. So user blacklists addthis.com to achieve this effect.

Please consider differentiating between blocked elements (pink color) and blacklisted hostnames (red color) in whether a placeholder is collapsed or not.

@gorhill gorhill closed this as completed in 73c8da0 Dec 8, 2017
Noxgrim pushed a commit to Noxgrim/uMatrix that referenced this issue Dec 29, 2021
Additionally, performance improvements:
- Reduce overhead of collapsing elements
  (see gorhill/uBlock#2839)
- Cache decomposition of source hostname when matrix-filtering

Also, various code review.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants