-
Notifications
You must be signed in to change notification settings - Fork 472
Make placeholders in iframes clickable #789
Comments
It is, the link is the up arrow. |
My bad. I didn't realize. Is there a reason why the URL is not clickable, but only the arrow is? |
I can't remember why -- I am guessing I wanted to be sure people wouldn't click reflexively on the link, it had to be a conscious action. |
Maybe it would make it more explict to replace the arrow by something like this: http://fontawesome.io/icon/external-link/ This is Wikipedia's one:
|
@emersion I find the arrow almost perfect, both noticeable when I look for it and not intrusive when I don't. Anyway, you are free to tweak it on your machine or fork it. |
Now I do, I will write it down before I forget again. You might not necessarily want to navigate to the URL as is, sometimes you may want to use the URL but without the added cruft at the end. Not making the whole URL a link makes easy to copy only a specific part of the URL -- something annoying/difficult to do when the whole text is a link. |
Commit 622d0a7 adds a placeholder in
<iframe>
.It would be useful to make the placeholder clickable (
<a href="{{url}}" target="_blank" rel="noreferrer noopener">
) to be able to open pages on a case-by-case basis.The text was updated successfully, but these errors were encountered: