Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Make placeholders in iframes clickable #789

Closed
emersion opened this issue May 23, 2017 · 6 comments
Closed

Make placeholders in iframes clickable #789

emersion opened this issue May 23, 2017 · 6 comments

Comments

@emersion
Copy link

emersion commented May 23, 2017

Commit 622d0a7 adds a placeholder in <iframe>.

It would be useful to make the placeholder clickable (<a href="{{url}}" target="_blank" rel="noreferrer noopener">) to be able to open pages on a case-by-case basis.

@emersion emersion changed the title Make link placeholders in iframes clickable Make placeholders in iframes clickable May 23, 2017
@gorhill
Copy link
Owner

gorhill commented May 23, 2017

It is, the link is the up arrow.

@emersion
Copy link
Author

My bad. I didn't realize.

Is there a reason why the URL is not clickable, but only the arrow is?

@gorhill
Copy link
Owner

gorhill commented May 23, 2017

I can't remember why -- I am guessing I wanted to be sure people wouldn't click reflexively on the link, it had to be a conscious action.

@emersion
Copy link
Author

Maybe it would make it more explict to replace the arrow by something like this: http://fontawesome.io/icon/external-link/

This is Wikipedia's one:

data:image/svg+xml,%3C%3Fxml version%3D"1.0" encoding%3D"UTF-8" standalone%3D"no"%3F%3E%3Csvg xmlns%3D"http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg" width%3D"12" height%3D"12"%3E%3Cpath fill%3D"%23fff" stroke%3D"%2306c" d%3D"M1.5 4.518h5.982V10.5H1.5z"%2F%3E%3Cpath d%3D"M5.765 1H11v5.39L9.427 7.937l-1.31-1.31L5.393 9.35l-2.69-2.688 2.81-2.808L4.2 2.544z" fill%3D"%2306f"%2F%3E%3Cpath d%3D"M9.995 2.004l.022 4.885L8.2 5.07 5.32 7.95 4.09 6.723l2.882-2.88-1.85-1.852z" fill%3D"%23fff"%2F%3E%3C%2Fsvg%3E

@leedoyle
Copy link

leedoyle commented Nov 13, 2017

@emersion I find the arrow almost perfect, both noticeable when I look for it and not intrusive when I don't. Anyway, you are free to tweak it on your machine or fork it.

gcb pushed a commit to gcb/uMatrix that referenced this issue Nov 17, 2017
@gorhill
Copy link
Owner

gorhill commented Nov 20, 2017

I can't remember why

Now I do, I will write it down before I forget again.

You might not necessarily want to navigate to the URL as is, sometimes you may want to use the URL but without the added cruft at the end. Not making the whole URL a link makes easy to copy only a specific part of the URL -- something annoying/difficult to do when the whole text is a link.

Noxgrim pushed a commit to Noxgrim/uMatrix that referenced this issue Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants