Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Placeholder in logger "Network error" message is not replaced #945

Closed
xofe opened this issue Feb 5, 2018 · 2 comments
Closed

Placeholder in logger "Network error" message is not replaced #945

xofe opened this issue Feb 5, 2018 · 2 comments

Comments

@xofe
Copy link
Contributor

xofe commented Feb 5, 2018

When an asset can't be downloaded, the message "Network error: Unable to connect to {{url}}" is shown in the logger with the {{url}} placeholder not replaced by the URL that failed to load. This is due to the line 104 of src/js/assets.js trying to replace {{msg}} instead of {{url}}.

I reported a similar issue a while ago for uBO (gorhill/uBlock#2921), which you understandably closed as an external translation issue, but for uMatrix this affects every language (including English) so seems like something that should be fixed in uMatrix itself.
gorhill added a commit that referenced this issue Apr 14, 2018
@gorhill
fix #995, #945; other minor fixes; opportunistic code review
fe995d2
@gorhill
Copy link
Owner

gorhill commented Apr 14, 2018

Fixed in fe995d2.

@gorhill gorhill closed this as completed Apr 14, 2018
@uBlock-user
Copy link
Contributor

uBlock-user commented Dec 30, 2019 •
edited
Loading

Bug is back in 1.4.1b3, block any HOSTS list url, force update that HOSTS list and check the logger for that msg.

@gorhill

gorhill added a commit that referenced this issue Dec 31, 2019
@gorhill
Fix network error message in logger
ea688f3 
Related feedback:
- #945 (comment)

Regression from:
- 9b292304d33a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gorhill @uBlock-user @xofe