fix: allowed content max height be applied for dynamic sizing

gorhom · Sep 17, 2023 · af53c28 · af53c28
1 parent 9564467
commit af53c28
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/src/components/bottomSheet/BottomSheet.tsx b/src/components/bottomSheet/BottomSheet.tsx
@@ -1180,17 +1180,6 @@ const BottomSheetComponent = forwardRef<BottomSheet, BottomSheetProps>(
       [_providedStyle, containerAnimatedStyle]
     );
     const contentContainerAnimatedStyle = useAnimatedStyle(() => {
-      /**
-       * if dynamic sizing is enabled, and content height
-       * is still not set, then we exit method.
-       */
-      if (
-        enableDynamicSizing &&
-        animatedContentHeight.value === INITIAL_CONTAINER_HEIGHT
-      ) {
-        return {};
-      }
-
       /**
        * if content height was provided, then we skip setting
        * calculated height.

diff --git a/src/components/bottomSheetScrollable/createBottomSheetScrollableComponent.tsx b/src/components/bottomSheetScrollable/createBottomSheetScrollableComponent.tsx
@@ -64,6 +64,7 @@ export function createBottomSheetScrollableComponent<T, P>(
       animatedFooterHeight,
       animatedScrollableState,
       animatedContentHeight,
+      enableDynamicSizing,
     } = useBottomSheetInternal();
     //#endregion
 
@@ -83,7 +84,9 @@ export function createBottomSheetScrollableComponent<T, P>(
     //#region callbacks
     const handleContentSizeChange = useStableCallback(
       (contentWidth: number, contentHeight: number) => {
-        animatedContentHeight.value = contentHeight;
+        if (enableDynamicSizing) {
+          animatedContentHeight.value = contentHeight;
+        }
 
         if (onContentSizeChange) {
           onContentSizeChange(contentWidth, contentHeight);