-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] | [v2] React 18 types #1098
Comments
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Please leave it open 🙏 |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Ping |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Ping |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Ping |
Ping |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Ping |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue was closed because it has been stalled for 5 days with no activity. |
Bug
React Native has been using React 18 since version 0.69. Therefore, it is recommended to also raise the resolution of
@types/react
package to version 18.With this version bump there were a few breaking changes, which we have already fixed in our repository. Unfortunately, the TypeScript compiler also complains about bugs in this package.
The option
skipLibCheck
has no effect here, because it only affects.d.ts
files. But this library also publishes the source.ts
files to NPM, so they are checked by the TypeScript compiler too.A potential fix would be to raise the version, but this is likely to cause problems for TypeScript users running version 17 of
@types/react
.An alternative solution would be to no longer publish the source files to NPM.
Environment info
Steps To Reproduce
@types/react
is used in version 18@gorhom/bottom-sheet
and use it somewheretsc --noEmit
Describe what you expected to happen:
That the TypeScript compile does not display any errors.
Reproducible sample code
Doesn't make sense here, since you can't run the TypeScript compiler check in an expo snack.
The text was updated successfully, but these errors were encountered: