Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React18 types #1123

Merged
merged 2 commits into from
Apr 30, 2023
Merged

React18 types #1123

merged 2 commits into from
Apr 30, 2023

Conversation

stropho
Copy link
Contributor

@stropho stropho commented Sep 30, 2022

Closes #1098

Motivation

  • update Typescript React annotations in order to make the library compatible with react 18 types
  • additionally, specific version of react types can be used and provided as optional peer dependecies

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@stropho
Copy link
Contributor Author

stropho commented Nov 1, 2022

yup, this is ready to be reviewed. Not sure what is it waiting for 😉

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@stropho
Copy link
Contributor Author

stropho commented Dec 3, 2022

Pretty please @gorhom :) Can anyone have look? There is absolutely no change in the implementation. Just the React types...

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@stropho
Copy link
Contributor Author

stropho commented Jan 10, 2023

still waiting :(

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@stropho
Copy link
Contributor Author

stropho commented Feb 20, 2023

ping @gorhom 😉

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@eps1lon
Copy link
Contributor

eps1lon commented Mar 31, 2023

#1335 is also required to be compatible with React 18 types and should probably merged regardless since getScrollResponder effectively returns {} i.e. any non-nullish value.

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@eps1lon
Copy link
Contributor

eps1lon commented Apr 30, 2023

bump

@gorhom gorhom added v4 Written in Reanimated v2 and removed no-pr-activity labels Apr 30, 2023
@gorhom gorhom self-assigned this Apr 30, 2023
@gorhom gorhom merged commit d41eda2 into gorhom:master Apr 30, 2023
gorhom pushed a commit that referenced this pull request Apr 30, 2023
@stropho @gorhom
chore: fixed types (#1123)(by @stropho)
b440964 
* fix: react 18 types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gorhom gorhom

Labels
v4 Written in Reanimated v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v4] | [v2] React 18 types
3 participants
@stropho @eps1lon @gorhom