-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BottomSheet Issue on Android 14 and iOS 17.1/17.2 #1674
Comments
I don't know it is same case with me. I comment additional environment of this bug. |
Same issue here |
@gorhom is there any solution for that please ? |
experiencing problems as well, any update @gorhom |
@jdicami It is related to reanimated with reduced motion, here is a patch that can temporarily fix this issue. |
thx @FawadMahmood your patch fix the issue |
@gorhom can we get this added in to the next release if possible? |
@daveosterjr, it needs to be appropriately implemented. I just made a quick patch. |
This has been causing some major issues for us on both iOS and Android. We love this library and have used it liberally across our app, which in turn made our app unusable for users on the problematic device/os combos. I applied the patch and its now fixed (Thank you @FawadMahmood!). Is there anything I can do to help get this fix moved into a release? |
Quick clarification to others who find this. Reduce motion is a phone setting...
When enabled the bottom sheet does not work |
+1 please and thanks!
|
I've submitted a PR which should fix this in v5 of the library: #1743 |
You can extend the
|
this should be fixed on |
@gorhom great to hear! This is a pretty big issue, are you able to give a rough timeline for when v5 is stable? |
This worked for me const reducedMotion = useReducedMotion(); animateOnMount={!reducedMotion} |
On changing the animationConfigs, the bottomSheet is finally starting to show, but I'm facing a new problem now. 3 out of 10 times the bottom sheet doesn't close properly with the close or dismiss function. It goes down and comes back up. Anyone else facing the same issue? |
@singhayush1403 I had the same issue and fixed it by applying the patch @FawadMahmood provided ! I hope it helps. |
gorhom#1674) fix: bottom sheet not appearing for users that have reduced motion turned on (gorhom#1743)(by @fobos531)
gorhom#1674) fix: bottom sheet not appearing for users that have reduced motion turned on (gorhom#1743)(by @fobos531)
bottom sheet not appearing for users that have reduced motion turned on (#1743 @fobos531) (9b4ef4d) |
Checked after upgrading to v5.0.0-alpha.8 but the issue seems to persist. The bottom sheet does not open the first time, I need to call The issue persists on RN version |
This is resolved here: https://github.com/gorhom/react-native-bottom-sheet/releases/tag/v5.0.0-alpha.8 |
I have encountered this, and its unrelated to the reduced motion. Whenever you change the animationConfig, this issue starts to arise. |
"Reduced Motion" breaks a lot of stuff in this library even previous to 17.1.. IE onClose handlers fire instantly... kind of makes it unusable IMO. In my current project we're going to have to swap out BottomSheet for our own bottom sheet component because of these issues |
I had the same issue and found that it happens when the I actually noticed the same issue when using I fixed it by declaring the config object outside the component, which keep the same reference between each render. import { ANIMATION_CONFIGS } from '@gorhom/bottom-sheet';
import { ReduceMotion } from 'react-native-reanimated';
// Constants
const bottomSheetAnimationConfig = {...ANIMATION_CONFIGS, reduceMotion: ReduceMotion.Never};
// In Component
<BottomSheet
animationConfigs={bottomSheetAnimationConfig} |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue was closed because it has been stalled for 5 days with no activity. |
Bug
The BottomSheet component of the @gorhom/bottom-sheet plugin is not functioning correctly on Android 14.
on iOS, it works on version 17.0 but does not work on versions 17.1 and 17.2.
Environment info
Steps To Reproduce
1.Open the app
2.Click on the button designed to display the BottomSheet.
3.The BottomSheet should open as a result of these steps, but it is not functioning as expected on Android 14 and iOS 17.1/17.2.
Describe what you expected to happen:
The BottomSheet should open .
Reproducible sample code
https://snack.expo.io/@gorhom/bottom-sheet-v4-reproducible-issue-template
The text was updated successfully, but these errors were encountered: