Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] BottomSheetModal content not accessible by screen reader on iOS #619

Closed
jangsoori opened this issue Sep 2, 2021 · 5 comments
Closed
Assignees
Labels
bug Something isn't working v4 Written in Reanimated v2

Comments

@jangsoori
Copy link

Bug

Contents of the BottomSheetModal component (also BottomSheet) are not accessible by screen reader on iOS.

Environment info

Library Version
@gorhom/bottom-sheet 4.0.2
react-native 0.63.3
react-native-reanimated 2.2.0
react-native-gesture-handler 1.10.2

Steps To Reproduce

  1. Turn on voice over in iOS accessibility settings
  2. Navigate to the application
  3. Open Bottom Sheet Modal
  4. Try to tap on elements inside. It will focus only the wrapper, but not contents

Describe what you expected to happen:

  1. Expect screen reader to focus and announce items contained within a Bottom Sheet.

Reproducible sample code

https://snack.expo.dev/@jangsoori/ashamed-kiwi

@jangsoori jangsoori added the bug Something isn't working label Sep 2, 2021
@jangsoori jangsoori changed the title [v4] | BottomSheetModal content not accessible by screen reader on iOS [v4] BottomSheetModal content not accessible by screen reader on iOS Sep 2, 2021
@gorhom gorhom self-assigned this Sep 2, 2021
@gorhom gorhom added the v4 Written in Reanimated v2 label Sep 2, 2021
gorhom added a commit that referenced this issue Sep 2, 2021
@gorhom
Copy link
Owner

gorhom commented Sep 2, 2021

thanks @jangsoori for reporting this issue, it should be resolved with v4.0.3 👏

@gorhom gorhom closed this as completed Sep 2, 2021
@thienautran
Copy link

@gorhom I'm using this on v4.6.1, and Voice over only announces "Bottom Sheet" when focus is placed over the bottom sheet. Even with elements inside the bottom sheet, the child elements cannot be accessed by Voice Over. Any idea what has regressed?

@nbarkoch
Copy link

@thienautran
in version v4.5.1 it still works, need to check within those last updates..

@kkureli
Copy link

kkureli commented Jun 13, 2024

In 4.5.1 it also as @thienautran said only announces "Bottom Sheet" when focus is placed over the bottom sheet, Even with elements inside the bottom sheet, the child elements cannot be accessed by Voice Over.

But it works in v4.0.3

@rafahlobo
Copy link

rafahlobo commented Aug 6, 2024

To solve this problem, simply pass the property "accessible={false}".

I tested it on version "@gorhom/bottom-sheet": "^4.6.1",

For example:

<BottomSheet
      accessible={false}      
      ....       
      />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v4 Written in Reanimated v2
Projects
None yet
Development

No branches or pull requests

6 participants