fix: crash on swipe down #1367
fix: crash on swipe down #1367
Conversation
| @@ -298,7 +297,7 @@ export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType = | |||
| absoluteY > WINDOW_HEIGHT - animatedKeyboardHeight.value | |||
| ) | |||
| ) { | |||
| dismissKeyboardOnJs(); | |||
| runOnJS(Keyboard.dismiss); | |||
There was a problem hiding this comment.
This will crash with reanimated > 3.x. My recommendation -> 94cf11e
There was a problem hiding this comment.
Hi,
I haven't tested on V3.
So it means we need to bump the required reanimated version on this lib?
Or what is your suggestion?
That way it crashes on reanimated < 3.x
Thanks
There was a problem hiding this comment.
Update:
I tested on "react-native-reanimated": "~3.1.0" and it works perfectly
There was a problem hiding this comment.
Just tested in "react-native-reanimated": "3.1.0".
There was a problem hiding this comment.
yes exactly, that is a fix that this PR has.
That was the cause of the issue.
There was a problem hiding this comment.
Tried this, but got this error now ReanimatedError: Trying to access property dismiss of an object which cannot be sent to the UI runtime., js engine: reanimated
There was a problem hiding this comment.
Tried this, but got this error now
ReanimatedError: Trying to access propertydismissof an object which cannot be sent to the UI runtime., js engine: reanimated
Same
There was a problem hiding this comment.
something like this works without problem (@LuisRego)
const dismissKeyboard = () => {
Keyboard.dismiss()
}
...
runOnJS(dismissKeyboard)();
|
Hi Guys, Update/Edit: Please take a look |
|
thanks @beqramo for submitting this CR , i will prepare a new patch release today with this fix <3 |
fix: crash on swipe down (gorhom#1367)
this PR fixes the issue faced here:
#1366
Motivation
keyboard close was being called incorrectly which was causing a crash on the device.
This fix was tested on device