-
-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added over drag support #139
Conversation
It'd be nice if one could over drag it to the upside by dragging anywhere on the modal instead of just the very top, like the way instagram does it |
@gorhom Any chance this comment above can land in V4? |
@lg9302 @pouyarezvani this is impossible - at least for any scrollable - because it will block the scrollable from scrolling 🤷♂️ however, you can overdrag to the bottom from any scrollable/content 👏 |
Yes it would be impossible for any scrollable content, but for the regular modal sheet it is possible |
@grifotv @gorhom Yeah it makes sense for it to not work in scrollable views. But what about if a view is not scrollable? Can it be achieved there? Could you possibly hint me how you are doing your over-drag which is only for the handle section so maybe I can tweak it to work with the whole body of the modal? |
Motivation
inspired by
reanimated-bottom-sheet
over drag featureOverDrag.mp4
Changelog
enableOverDrag
&overDragResistanceFactor
propsanimationConfigs
to customise animation configuration and type.useBottomSheetSpringConfigs
&useBottomSheetTimingConfigs
to create a memoized animation configs