Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added over drag support #139

Merged
merged 11 commits into from
Jan 2, 2021
Merged

feat: added over drag support #139

merged 11 commits into from
Jan 2, 2021

Conversation

gorhom
Copy link
Owner

@gorhom gorhom commented Jan 2, 2021

Motivation

inspired by reanimated-bottom-sheet over drag feature

OverDrag.mp4

Changelog

  • added enableOverDrag & overDragResistanceFactor props
  • added animationConfigs to customise animation configuration and type.
  • added useBottomSheetSpringConfigs & useBottomSheetTimingConfigs to create a memoized animation configs

@gorhom gorhom added the v3 Written in Reanimated v2 label Jan 2, 2021
@gorhom gorhom merged commit 36c2993 into v3 Jan 2, 2021
@gorhom gorhom deleted the feature/add-over-drag-support branch January 2, 2021 16:15
@TransLover
Copy link

It'd be nice if one could over drag it to the upside by dragging anywhere on the modal instead of just the very top, like the way instagram does it

@pouyarezvani
Copy link

pouyarezvani commented Jun 16, 2021

@lg9302 @gorhom This would be very Awesome!
Can we expect this to happen @gorhom?

@pouyarezvani
Copy link

@gorhom Any chance this comment above can land in V4?

@gorhom
Copy link
Owner Author

gorhom commented Jun 22, 2021

@lg9302 @pouyarezvani this is impossible - at least for any scrollable - because it will block the scrollable from scrolling 🤷‍♂️

however, you can overdrag to the bottom from any scrollable/content 👏

@TransLover
Copy link

@lg9302 @pouyarezvani this is impossible - at least for any scrollable - because it will block the scrollable from scrolling 🤷‍♂️

however, you can overdrag to the bottom from any scrollable/content 👏

Yes it would be impossible for any scrollable content, but for the regular modal sheet it is possible

@pouyarezvani
Copy link

@grifotv @gorhom Yeah it makes sense for it to not work in scrollable views. But what about if a view is not scrollable? Can it be achieved there? Could you possibly hint me how you are doing your over-drag which is only for the handle section so maybe I can tweak it to work with the whole body of the modal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 Written in Reanimated v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants