Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock BottomSheet list with ReactNative list equivalent #1394

Merged
merged 1 commit into from
Jun 23, 2023
Merged

mock BottomSheet list with ReactNative list equivalent #1394

merged 1 commit into from
Jun 23, 2023

Conversation

gkueny
Copy link
Contributor

@gkueny gkueny commented Jun 7, 2023

Motivation

In react-native, if we run test on component where we use BottomSheetScrollView / BottomSheetSectionList / BottomSheetFlatList BottomSheetVirtualizedList with @gorhom/bottom-sheet/mock mock, It doesn't work. The content of these components is not rendered.

That's because these components are replaced by BottomSheetComponent which does not implement renderItem props.

Solution

Using react-native components is equivalent to solving the above-mentioned problem.

@gorhom gorhom added v4 Written in Reanimated v2 v5 labels Jun 23, 2023
@gorhom
Copy link
Owner

gorhom commented Jun 23, 2023

thanks for submitting this CR

@gorhom gorhom merged commit ea03e78 into gorhom:master Jun 23, 2023
gorhom pushed a commit that referenced this pull request Jun 23, 2023
@gkueny @gorhom
fix: updated scrollables mocks with ReactNative list equivalent (#1394)…
630f87f 
…(by @gkueny)
@luizprsjr luizprsjr mentioned this pull request Oct 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v4 Written in Reanimated v2 v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkueny @gorhom