fix(BottomSheetTextInput): reset shouldHandleKeyboardEvents on unmount #1495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request resets shouldHandleKeyboardEvents flag on BottomSheetTextInput unmount
Motivation
For my project, I'm using a system where I'm reusing a single BottomSheet and I'm mounting and unmounting the content (can be different) as it opens and closes.
This approach triggers the following issue: often, when I unmount the content of the BottomSheet and a BottomSheetTextInput is focused, the blur event doesn't get handled at all, and this causes the BottomSheet to show up whenever I open a keyboard from an unrelated place.
The fix is simple: I just reset the flag whenever an unmount happens.
Before
Screen.Recording.2023-08-23.at.20.54.33.mov
After
Screen.Recording.2023-08-23.at.20.55.45.mov