fix: unmounting modals with navigation

[gorhom]

Resolves #292 #299

Motivation

to provide better handling when unmounting modals due to navigation changes

Installation

yarn add ssh://git@github.com:gorhom/react-native-bottom-sheet#fix/unmounting-modals-with-navigation

[gorhom]

@chybisov & @ksitko could you test this pr, thanks :)

[ksitko]

@gorhom The pr resolves the crash :)
I seem to be getting a state update on an unmounted component warning though:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.

@chybisov Are you getting the same or is this just me?

[gorhom]

@ksitko thanks for testing it and reporting this warning, i'll look into it shortly

[gorhom]

@ksitko i have pushed a commit that will prevent state update when modal is not mounted 👍

[ksitko]

@gorhom Nice! I can confirm that latest commit fixed the warning. I found a different problem. When not in dev mode I'm getting a crash on opening a bottom model sheet with a "TypeError Attempted to assign to readonly property" error message.

[gorhom]

@ksitko thanks for pointing this issue out, it was with the new release of portal, i have fixed this now on both repos.

would you mind testing the latest commit, thanks :)

[ksitko]

@gorhom Latest commit looks good. Thanks for the speedy fixes! :D