refactor: converted all internal state/memoized variables to reanimated shared values. #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @gorhom stack navigator in bootomsheet and I have different action button to all stack navigator screen so can I use BottomSheetFooter only in stack navigator child screens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#427
Motivation
I have refactored the library to use shared values to store and update layout values.
Notice
Calculating snap points position had change in this branch, now the library will count the handle height when positioning the sheet. This is a breaking change and will require developers to carefully monitor the change.
This is how you can visualise it:
Installation