Don't set a default samesite for backwards compatibility #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a comment over SameSiteDefaultMode discouraging its use.
The specific issue I ran into is that the default behaviour of
gorilla/csrf
is to include an invalidSameSite
attribute on the cookie without doing anySameSite
configuration.This broke some users of the site in question because older versions of chrome (apparently the version shipped with android 8) treats an invalid samesite attribute as grounds to drop the cookie entirely rather than just default it to lax.
This updates it to use the zero-value by default for
http.SameSite
rather thanSameSiteDefaultMode
, which has different behaviour from the zero value.xref golang/go#36990 which, when resolved, may inform this. I do think that no matter how that issue is resolved, the better default for
opts.SameSite
here is0
though.