Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support JSON Feed 1.1 closes #91 #104

Merged
merged 1 commit into from
Sep 26, 2023
Merged

feat: support JSON Feed 1.1 closes #91 #104

merged 1 commit into from
Sep 26, 2023

Conversation

meblum
Copy link
Contributor

@meblum meblum commented Sep 22, 2023

What type of PR is this? (check all applicable)

  • Feature

Description

Related Tickets & Documents

closes #91

Added/updated tests?

  • Yes

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #104 (5c0d5a2) into main (3bdeb10) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   81.07%   81.33%   +0.26%     
==========================================
  Files           5        5              
  Lines         280      284       +4     
==========================================
+ Hits          227      231       +4     
  Misses         45       45              
  Partials        8        8              
Files Coverage Δ
json.go 59.77% <100.00%> (+1.93%) ⬆️

Copy link
Member

@AlexVulaj AlexVulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this in, looks good to me

@AlexVulaj AlexVulaj merged commit 4546219 into gorilla:main Sep 26, 2023
9 checks passed
@meblum
Copy link
Contributor Author

meblum commented Sep 26, 2023

@AlexVulaj Thanks for merging! Can we please have a new tagged release published? Given that we now generate JSON Feed 1.1 and have fixed that issue that could cause panics, I think it makes sense to create a new tag so consumers of the module will benefit of these updates.

@AlexVulaj
Copy link
Member

@meblum we're discussing what we want our release process to look like currently, but this repo will be one of the first to go once that's squared away!

@meblum
Copy link
Contributor Author

meblum commented Sep 28, 2023

I appreciate that, thank you!

Bios-Marcel pushed a commit to Bios-Marcel/feeds that referenced this pull request Apr 27, 2024
## What type of PR is this? (check all applicable)

- [x] Feature

## Description

## Related Tickets & Documents
closes gorilla#91

## Added/updated tests?

- [x] Yes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[feature] Support JSON feed v1.1
2 participants