Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix JSONFeed Hubs #74

Merged
merged 3 commits into from
Jul 26, 2019
Merged

fix JSONFeed Hubs #74

merged 3 commits into from
Jul 26, 2019

Conversation

wybiral
Copy link
Contributor

@wybiral wybiral commented Jul 21, 2019

Fixes: JSONFeed.Hubs attribute was of type []*JSONItem when it should have been []*JSONHub.

Summary of Changes

  1. Changed type of JSONFeed.Hubs from []*JSONItem to []*JSONHub.

@elithrar
Copy link
Contributor

Thanks - can you add a test that covers this?

@wybiral
Copy link
Contributor Author

wybiral commented Jul 25, 2019

Sure, b194c17 will make sure that the type is correct and that JSONFeed serializes correctly with hubs.

This change doesn't impact other feed types since this package doesn't support hubs for them (although technically Atom feeds can support hubs using links with rel="hub" which could translate to JSONFeed).

@elithrar
Copy link
Contributor

Perfect; thanks @wybiral!

@elithrar elithrar merged commit 6f6e20d into gorilla:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants