[bug] RSS Item link should be optional #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure seems to be unrelated. |
amustaque97
approved these changes
Nov 15, 2022
elithrar
approved these changes
Nov 15, 2022
jlelse
pushed a commit
to jlelse/feeds
that referenced
this pull request
Jul 7, 2023
Bios-Marcel
pushed a commit
to Bios-Marcel/feeds
that referenced
this pull request
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RSS specification the
<link>tag in<item>is optional. Such usage currently fails with this library:feeds/rss.go
Line 98 in 6f6e20d
Because of course in that case
i.Linkis nil so we can't get aHreffrom it.