-
Notifications
You must be signed in to change notification settings - Fork 272
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(Combined)LoggingHandler: Add Go 1.8 http.Pusher support
When building with Go 1.8, embed http.Pusher interface in loggingResponseWriter interface and define a Push wrapper method on responseLogger. Without this change, users of handlers.LoggingHandler or handlers.CombinedLoggingHandler cannot take advantage of the new http.Pusher interface since responseLogger does not satisfy the http.Pusher interface. When building with pre-1.8 Go, the loggingResponseWriter and responseLogger types remain unchanged.
- Loading branch information
Niels Widger
committed
Feb 9, 2017
1 parent
3a5767c
commit 356173f
Showing
3 changed files
with
29 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// +build go1.8 | ||
|
||
package handlers | ||
|
||
import ( | ||
"fmt" | ||
"net/http" | ||
) | ||
|
||
type loggingResponseWriter interface { | ||
commonLoggingResponseWriter | ||
http.Pusher | ||
} | ||
|
||
func (l *responseLogger) Push(target string, opts *http.PushOptions) error { | ||
p, ok := l.w.(http.Pusher) | ||
if !ok { | ||
return fmt.Errorf("responseLogger does not implement http.Pusher") | ||
} | ||
return p.Push(target, opts) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// +build !go1.8 | ||
|
||
package handlers | ||
|
||
type loggingResponseWriter interface { | ||
commonLoggingResponseWriter | ||
} |