Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#739): Remove else statement on route mismatch #746

Conversation

marcelom97
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

When a path with specific query params does not match we should return a ErrMethodMismatch instead of ErrNotFound

Related Tickets & Documents

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

When a path with specific query params does not match we should return a ErrMethodMismatch instead of ErrNotFound
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 21, 2023
@jaitaiwan jaitaiwan self-assigned this Jan 17, 2024
@jaitaiwan
Copy link
Member

I've reviewed and I'm happy with the code and tests to match. What needs to be considered now is if this is technically a breaking api change or not as folks utilising the library may expect the former error. @AlexVulaj would love your input on this.

@jaitaiwan
Copy link
Member

jaitaiwan commented Jan 22, 2024

Actually I got confused - this PR (thanks to #748) is now obsolete. Thank you heaps for the contribution @marcelom97. If you feel that this was in error, please open up another issue to discuss.

@jaitaiwan jaitaiwan closed this Jan 22, 2024
@marcelom97 marcelom97 deleted the fix/#739-MethodNotAllowedHandler-does-not-work-for-subrouter branch January 22, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MethodNotAllowedHandler does not work for subrouter with different routes
2 participants