add sha256 files and update README #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelsabbahy
requested changes
Apr 2, 2020
johnk-novu
changed the title
pedroMMM
approved these changes
Apr 5, 2020
|
Wonder if this hit the travis outage. I don't see a build for this. I'm going to go ahead and click the "update branch" button in the hopes that it triggers travis. |
|
Cool, that worked. The correct files seem to be generated in travis. Hopefully the next release has them |
|
Thank you for your contribution |
BenjaminHerbert
pushed a commit
to BenjaminHerbert/goss
that referenced
this pull request
May 28, 2020
* add sha256 files and update README * add target to compute sha256 for dgoss * empty commit to trigger ci from when github was down * PR feedback Co-authored-by: Ahmed Elsabbahy <aelsabbahy@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Generate and publish sha256 of each "release" file. Update README for usage.
I am not sure if the travis tests will work, or how the files would get published to GitHub releases exactly.
Issue: #447
TODO: I still need to get the dgoss.sha256 generated in the Makefile.If #567 is merged first, I will resolve the resulting merge conflicts (and vice-versa if this one is merged first).