Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'release/' from checksum file #590

Closed
wants to merge 2 commits into from

Conversation

diraol
Copy link

@diraol diraol commented May 27, 2020

By having <sha256> release/goss... this prevents from automating the
check between the sha and the file, since sha256sum will try to find the
goss file within the release directory and usually, while automating goss
installation, we have them both in the same path and run the check from
this path, not from outside a release directory.

Relates to: #447

By having `<sha256> release/goss...` this prevents from automating the
check between the sha and the file, since sha256sum will try to find the
goss file within the `release` directory.
Copy link
Member

@aelsabbahy aelsabbahy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, I wonder if it can be implemented without running sed on the Sha file

Makefile Outdated Show resolved Hide resolved
@aelsabbahy
Copy link
Member

Travis-CI failed :( seems there's something in the makefile that's broken.

Using makefile syntax instead of shell/sed
@diraol
Copy link
Author

diraol commented Jun 1, 2020

Oh man, sorry, I didn't received Travis-ci failed build feedback.

I guess it was missing a Tab character, I've edited it, let's see. :)

@diraol
Copy link
Author

diraol commented Jun 1, 2020

Ok, all good now, I guess :)

@aelsabbahy
Copy link
Member

#585 conflicted with this in a major way (re-wrote a lot of this code).

I ended up creating #592 to fix this.

Thank you for taking the time to implement this, sorry it ended up conflicting with a much bigger change.

@aelsabbahy aelsabbahy closed this Jun 16, 2020
@diraol diraol deleted the dro/improve_sha_file branch June 18, 2020 22:15
@diraol
Copy link
Author

diraol commented Jun 18, 2020

No problem at all, glad to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants