Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build on RHEL6,7 (proper cmake is cmake3) #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chipitsine
Copy link

No description provided.

@vbwagner
Copy link
Contributor

vbwagner commented Jun 6, 2018

Where do you get openssl 1.1 for RHEL7? I haven't bother to support ancient version of cmake in RHEL/CentOS/Oracle linux, because they don't include openssl 1.1 anyway.

@chipitsine
Copy link
Author

RHEL7 is not ancient. it is still supported. surprize, it is the latest RHEL

we roll our own RPM with openssl-1.1.0

@vbwagner
Copy link
Contributor

vbwagner commented Jun 6, 2018

cmake3 is missing from RHEL distribution. One need to add EPEL repositories to be able to download it
But if one have EPEL, it is available for centos 6 releases as well. And your pull request doesn't support it. (and it is still siupported too).

@chipitsine
Copy link
Author

what I'm going to do (in mid term) is to create Fedora COPR repo with supported builds.

I haven't decided yet whether to support RHEL6 or not (we do not use it, so I can leave it to people who really needs it, right?)

currently, we deploy engine on RHEL7, so I adopted build system to it. unfortunately, I cannot write in spec "it depends on EPEL, only certain packages like cmake3"

@chipitsine
Copy link
Author

wait a moment. I'll do smoke test on CentOS 6

@chipitsine chipitsine changed the title fix build on RHEL7 (proper cmake is cmake3) fix build on RHEL6,7 (proper cmake is cmake3) Jun 6, 2018
@chipitsine
Copy link
Author

is it ok now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants