ipython5 use TerminalInteractiveShell debugger_cls solution for #105

[JBKahn]

A solution for #105
It seems like a good place to start getting the ball rolling. Thoughts?

[JBKahn]

alternatively I was going to define it as a function rather than at import time, which now that I think about it, sounds much better.

[JBKahn]

@gotcha just a friendly reminder.

[jakul]

I have this problem too, what can we do to get this fix merged?

[bar]

@JBKahn @gotcha any reason for not merging the fix? danke

[JBKahn]

@bar I think it's just a matter of @gotcha currently being inactive. None of the other PRs or issues are currently progressing either. Hopefully he'll return soon.

[sinanm89]

This fixes ipdb completely for me when im trying to work with twisted code. Thanks!

[gnebehay]

Hi, I'm a new collaborator on ipdb. I'm looking to clean up all old issues and PRs. This one seems rather important. Could you give me just a brief executive summary why using debugger_cls solves the problem, I somehow fail to see the point.

[gnebehay]

Ah, I see, there is this line in https://github.com/ipython/ipython/blob/master/IPython/terminal/interactiveshell.py#L115

    @property
    def debugger_cls(self):
        return Pdb if self.simple_prompt else TerminalPdb

Ok, merge is in the making.

[gnebehay]

I merged the changes here: https://github.com/gotcha/ipdb/tree/fix-use-debugger_cls Could you check if that works for you?

[JBKahn]

Will check this weekend, thanks!

[JBKahn]

@gnebehay seems to work just fine with a quick test 👍