Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: message id buffer #159

Merged
merged 2 commits into from
Feb 21, 2021
Merged

feat: message id buffer #159

merged 2 commits into from
Feb 21, 2021

Conversation

ernado
Copy link
Member

@ernado ernado commented Feb 21, 2021

Fix #157

This is part of replay attack mitigation.
@ernado ernado added area: client telegram package issues security Security-related issues labels Feb 21, 2021
@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #159 (ea71050) into main (f61460f) will increase coverage by 0.28%.
The diff coverage is 82.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   68.25%   68.53%   +0.28%     
==========================================
  Files         178      178              
  Lines        5059     5127      +68     
==========================================
+ Hits         3453     3514      +61     
- Misses       1245     1250       +5     
- Partials      361      363       +2     
Impacted Files Coverage Δ
mtproto/read.go 50.53% <0.00%> (-3.31%) ⬇️
internal/proto/message_id.go 96.15% <82.35%> (-3.85%) ⬇️
mtproto/conn.go 78.20% <100.00%> (+0.28%) ⬆️
internal/gen/templates.go 100.00% <0.00%> (ø)
internal/gen/make_interfaces.go 100.00% <0.00%> (ø)
internal/gen/write_source.go 63.23% <0.00%> (+0.54%) ⬆️
internal/gen/generator.go 68.00% <0.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61460f...ea71050. Read the comment docs.

@ernado ernado merged commit 5b8019f into main Feb 21, 2021
@ernado ernado deleted the feat/message-id-buf branch February 21, 2021 07:00
@ernado ernado mentioned this pull request Mar 11, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: client telegram package issues security Security-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client: check msg_id for replay attacks
1 participant