-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3 - with full go module support #140
Release v3 - with full go module support #140
Conversation
e587163
to
4c906a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 29 29
Lines 2038 2038
=======================================
Hits 1695 1695
Misses 236 236
Partials 107 107
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 82.8% 82.72% -0.09%
==========================================
Files 29 29
Lines 2030 2020 -10
==========================================
- Hits 1681 1671 -10
Misses 242 242
Partials 107 107
Continue to review full report at Codecov.
|
I would prefer "Major subdirectory:" solution as it provides the greatest backwards compatibility (to support ~1.8). That said, I feels it would be way more work for not too much… so, I think SGTM but I'm not sure I see all the implication (as, running Any way, we're doing what the go docs says, and we gotta start somewhere so… LGTM :wink: |
4c906a1
to
57bf5cd
Compare
To properly support go modules we need a new import path. Following https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher the correct way to do that seems to be to release a new major version.
57bf5cd
to
172219a
Compare
To properly support go modules we need a new import path. Following https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher the correct way to do that seems to be to release a new major version.
According to those docs this will be supported by the latest patch release of go1.9 and go1.10 as well.
Closes #156