-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests with latest go cmp #158
Fix tests with latest go cmp #158
Conversation
Looks like tests are failing (on older Go versions?) @dnephin |
Ya, I'd like to find a way to test it that works with all versions |
I ran into this test error randomly, even with the PR patch applied:
It turns out that go-cmp 0.3.0, the report randomly chooses between normal space (0x20) and non-breaking space (0xa0) in the report... I just got bitten by this in Debian packaging, as one build succeeds and yet the next build fails even though I did not change anything. See google/go-cmp#124 for the whole story. |
Change the expected value for a couple of them to be less strict
ca155ff
to
85ad333
Compare
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 29 29
Lines 2038 2038
=======================================
Hits 1695 1695
Misses 236 236
Partials 107 107
Continue to review full report at Codecov.
|
e852c27
to
0c37552
Compare
It is not clear to me why this behaviour changed in go-cmp 0.3, but it seems to behave differently in newer go versions
0c37552
to
41b481e
Compare
Alright, tests seem to be passing now |
Fixes #155