Merge pull request #44 from dnephin/fix-use-of-iota

Fix summary iota
gotestyourself · Feb 17, 2019 · 308fb9a · 308fb9a
2 parents cec68c0 + c96a20a
commit 308fb9a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/flags_test.go b/flags_test.go
@@ -8,7 +8,7 @@ import (
 
 func TestNoSummaryValue_SetAndString(t *testing.T) {
 	t.Run("none", func(t *testing.T) {
-		assert.Equal(t, newNoSummaryValue().String(), "")
+		assert.Equal(t, newNoSummaryValue().String(), "none")
 	})
 	t.Run("one", func(t *testing.T) {
 		value := newNoSummaryValue()

diff --git a/testjson/printer.go → testjson/format.go b/testjson/printer.go → testjson/format.go
diff --git a/testjson/printer_test.go → testjson/format_test.go b/testjson/printer_test.go → testjson/format_test.go
diff --git a/testjson/summary.go b/testjson/summary.go
@@ -16,8 +16,8 @@ type Summary int
 
 // nolint: golint
 const (
-	SummarizeNone Summary = 1 << (iota * 2)
-	SummarizeSkipped
+	SummarizeNone    Summary = 0
+	SummarizeSkipped Summary = (1 << iota) / 2
 	SummarizeFailed
 	SummarizeErrors
 	SummarizeOutput
@@ -45,7 +45,7 @@ func (s Summary) String() string {
 		return "none"
 	}
 	var result []string
-	for v := SummarizeNone; v <= s; v = v << 1 {
+	for v := Summary(1); v <= s; v = v << 1 {
 		if s.Includes(v) {
 			result = append(result, summaryValues[v])
 		}