-
Notifications
You must be signed in to change notification settings - Fork 118
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Return artificial events to Handler for missing events
This fixes a bug, and prevents one in the new rerun-fails feature. Incomplete tests were printed in the summary, but never passed to the EventHandler. Now when the execution ends, fake TestEVent will be created and sent to the Handler, so that it can print the output of the failed test. This allows the rerun-fails loop to include these failed tests in the count, and avoid a situation where a test was panicing, but not getting rerun. If the panic test did not get rerun then 'go test' may exit 0, making it look like everything had passed, when in fact one test was still panicing. This type of bug sounds pretty severe.
- Loading branch information
Showing
5 changed files
with
77 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
FAIL gotest.tools/v3/poll | ||
=== RUN TestWaitOn_WithCompare | ||
panic: runtime error: index out of range [1] with length 1 | ||
|
||
goroutine 7 [running]: | ||
gotest.tools/v3/internal/assert.ArgsFromComparisonCall(0xc0000552a0, 0x1, 0x1, 0x1, 0x0, 0x0) | ||
/home/daniel/pers/code/gotest.tools/internal/assert/result.go:102 +0x9f | ||
gotest.tools/v3/internal/assert.runComparison(0x6bcb80, 0xc00000e180, 0x67dee8, 0xc00007a9f0, 0x0, 0x0, 0x0, 0x7f7f4fb6d108) | ||
/home/daniel/pers/code/gotest.tools/internal/assert/result.go:34 +0x2b1 | ||
gotest.tools/v3/internal/assert.Eval(0x6bcb80, 0xc00000e180, 0x67dee8, 0x627660, 0xc00007a9f0, 0x0, 0x0, 0x0, 0x642c60) | ||
/home/daniel/pers/code/gotest.tools/internal/assert/assert.go:56 +0x2e4 | ||
gotest.tools/v3/poll.Compare(0xc00007a9f0, 0x6b74a0, 0x618a60) | ||
/home/daniel/pers/code/gotest.tools/poll/poll.go:151 +0x81 | ||
gotest.tools/v3/poll.TestWaitOn_WithCompare.func1(0x6be4c0, 0xc00016c240, 0xc00016c240, 0x6be4c0) | ||
/home/daniel/pers/code/gotest.tools/poll/poll_test.go:81 +0x58 | ||
gotest.tools/v3/poll.WaitOn.func1(0xc00001e3c0, 0x67df50, 0x6c1960, 0xc00016c240) | ||
/home/daniel/pers/code/gotest.tools/poll/poll.go:125 +0x62 | ||
created by gotest.tools/v3/poll.WaitOn | ||
/home/daniel/pers/code/gotest.tools/poll/poll.go:124 +0x16f | ||
FAIL gotest.tools/v3/poll.TestWaitOn_WithCompare (-1.00s) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters