Test go 1.11

gotestyourself · Aug 28, 2018 · 9dc8d56 · 9dc8d56
1 parent 8fced02
commit 9dc8d56
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 4 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -48,6 +48,24 @@ jobs:
       - store_test_results:
           path: junit/
 
+  test-golang-1.11:
+    working_directory: /work
+    docker: [{image: 'docker:17.06-git'}]
+    steps:
+      - checkout
+      - setup_remote_docker
+      - run:
+          name: "Unit Test GO 1.11"
+          command: |
+            scripts/ci/test 1.11-alpine
+            mkdir -p junit/gotest
+            docker cp \
+                test-$CIRCLE_BUILD_NUM:/go/src/gotest.tools/gotestsum/junit.xml \
+                junit/gotest/junit.xml
+
+      - store_test_results:
+          path: junit/
+
   release:
     docker: [{image: 'circleci/golang:1.10'}]
     working_directory: /go/src/gotest.tools/gotestsum
@@ -67,6 +85,7 @@ workflows:
     jobs:
       - lint
       - test-golang-1.10
+      - test-golang-1.11
       - release:
           filters:
             tags: {only: '/v[0-9]+(\.[0-9]+)*/'}

diff --git a/internal/junitxml/report.go b/internal/junitxml/report.go
@@ -80,9 +80,11 @@ func generate(exec *testjson.Execution) JUnitTestSuites {
 	return suites
 }
 
+var goVersion = runtime.Version()
+
 func packageProperties() []JUnitProperty {
 	return []JUnitProperty{
-		{Name: "go.version", Value: runtime.Version()},
+		{Name: "go.version", Value: goVersion},
 	}
 }
 

diff --git a/internal/junitxml/report_test.go b/internal/junitxml/report_test.go
@@ -15,6 +15,7 @@ func TestWrite(t *testing.T) {
 	out := new(bytes.Buffer)
 	exec := createExecution(t)
 
+	defer patchGoVersion("go7.7.7")()
 	err := Write(out, exec)
 	assert.NilError(t, err)
 	golden.Assert(t, out.String(), "junitxml-report.golden")
@@ -45,3 +46,11 @@ func (s *noopHandler) Event(testjson.TestEvent, *testjson.Execution) error {
 func (s *noopHandler) Err(string) error {
 	return nil
 }
+
+func patchGoVersion(version string) func() {
+	orig := goVersion
+	goVersion = version
+	return func() {
+		goVersion = orig
+	}
+}
diff --git a/internal/junitxml/testdata/junitxml-report.golden b/internal/junitxml/testdata/junitxml-report.golden
@@ -2,15 +2,15 @@
 <testsuites>
 	<testsuite tests="0" failures="0" time="0.000s" name="github.com/gotestyourself/gotestyourself/testjson/internal/badmain">
 		<properties>
-			<property name="go.version" value="go1.10.3"></property>
+			<property name="go.version" value="go7.7.7"></property>
 		</properties>
 		<testcase classname="." name="TestMain" time="0.000s">
 			<failure message="Failed" type="">sometimes main can exit 2&#xA;FAIL&#x9;github.com/gotestyourself/gotestyourself/testjson/internal/badmain&#x9;0.010s&#xA;</failure>
 		</testcase>
 	</testsuite>
 	<testsuite tests="18" failures="0" time="0.020s" name="github.com/gotestyourself/gotestyourself/testjson/internal/good">
 		<properties>
-			<property name="go.version" value="go1.10.3"></property>
+			<property name="go.version" value="go7.7.7"></property>
 		</properties>
 		<testcase classname="good" name="TestSkipped" time="0.000s">
 			<skipped message="=== RUN   TestSkipped&#xA;--- SKIP: TestSkipped (0.00s)&#xA;&#x9;good_test.go:23: &#xA;"></skipped>
@@ -37,7 +37,7 @@
 	</testsuite>
 	<testsuite tests="28" failures="4" time="0.020s" name="github.com/gotestyourself/gotestyourself/testjson/internal/stub">
 		<properties>
-			<property name="go.version" value="go1.10.3"></property>
+			<property name="go.version" value="go7.7.7"></property>
 		</properties>
 		<testcase classname="stub" name="TestFailed" time="0.000s">
 			<failure message="Failed" type="">=== RUN   TestFailed&#xA;--- FAIL: TestFailed (0.00s)&#xA;&#x9;stub_test.go:34: this failed&#xA;</failure>