Merge pull request #280 from gotestyourself/error-when-failfast-with-…

…rerun

Error if `-failfast` is used with `--rerun-fails`

cmd/main.go

@@ -174,9 +174,13 @@ type options struct {
 func (o options) Validate() error {
 	if o.rerunFailsMaxAttempts > 0 && len(o.args) > 0 && !o.rawCommand && len(o.packages) == 0 {
 		return fmt.Errorf(
-			"when go test args are used with --rerun-fails-max-attempts " +
+			"when go test args are used with --rerun-fails " +
 				"the list of packages to test must be specified by the --packages flag")
 	}
+	if o.rerunFailsMaxAttempts > 0 && boolArgIndex("failfast", o.args) > -1 {
+		return fmt.Errorf("-failfast can not be used with --rerun-fails " +
+			"because not all test cases will run")
+	}
 	return nil
 }
 

cmd/main_test.go

@@ -70,6 +70,11 @@ func TestOptions_Validate_FromFlags(t *testing.T) {
 			name: "rerun flag, no go-test args, with packages flag",
 			args: []string{"--rerun-fails", "--packages", "./..."},
 		},
+		{
+			name:     "rerun-fails with failfast",
+			args:     []string{"--rerun-fails", "--packages=./...", "--", "-failfast"},
+			expected: "-failfast can not be used with --rerun-fails",
+		},
 	}
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {