Fix empty package check in dot format

gotestyourself · Dec 10, 2022 · fb867e3 · fb867e3
1 parent b212ffd
commit fb867e3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/internal/junitxml/report.go b/internal/junitxml/report.go
@@ -105,7 +105,7 @@ func generate(exec *testjson.Execution, cfg Config) JUnitTestSuites {
 	}
 	for _, pkgname := range exec.Packages() {
 		pkg := exec.Package(pkgname)
-		if cfg.HideEmptyPackages && pkg.Total == 0 && !pkg.TestMainFailed() {
+		if cfg.HideEmptyPackages && pkg.IsEmpty() {
 			continue
 		}
 		junitpkg := JUnitTestSuite{

diff --git a/testjson/dotformat.go b/testjson/dotformat.go
@@ -103,7 +103,7 @@ func (d *dotFormatter) Format(event TestEvent, exec *Execution) error {
 
 	sort.Slice(d.order, d.orderByLastUpdated)
 	for _, pkg := range d.order {
-		if d.opts.HideEmptyPackages && exec.Package(pkg).Total == 0 {
+		if d.opts.HideEmptyPackages && exec.Package(pkg).IsEmpty() {
 			continue
 		}
 

diff --git a/testjson/execution.go b/testjson/execution.go
@@ -232,6 +232,11 @@ func (p *Package) TestMainFailed() bool {
 	return p.action == ActionFail && len(p.Failed) == 0
 }
 
+// IsEmpty returns true if this package contains no tests.
+func (p *Package) IsEmpty() bool {
+	return p.Total == 0 && !p.TestMainFailed()
+}
+
 const neverFinished time.Duration = -1
 
 // end adds any tests that were missing an ActionFail TestEvent to the list of