Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cross-platform tool for desktop notifications using --post-run-command #116

Open
dnephin opened this issue May 16, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dnephin
Copy link
Member

dnephin commented May 16, 2020

Building on #74 (#76) it would be nice to have a cross-platform way of using desktop notifications.

I'd like to avoid additional golang dependencies in gotestsum and use the os/exec approach for running the notification.

A couple options that come to mind:

  1. If there are widely used CLI tools (such as terminal-notifier in contrib/notify/notify-macos.go) we could add a new cmd/tool/notify which detects which CLI is available and shells out to the correct CLI
  2. We could build a separate binary using something like https://github.com/martinlindhe/notify and make it available to download from the github releases page.
@dnephin dnephin added enhancement New feature or request help wanted Extra attention is needed labels May 16, 2020
@ShiinaOrez
Copy link

Good issue, and cross-platform is important, I prefer to option 2, call notifier without user permission isn't a good behavior. Build a light and cross-platform notifier is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants