Add post-run-command hook #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
add-post-run-command
branch
2 times, most recently
from
d883f34
to
c9099d1
Compare
Pass environment variables with some summary info
dnephin
force-pushed
the
add-post-run-command
branch
3 times, most recently
from
9ab2a93
to
75d8d28
Compare
Using shlex to parse the command to avoid needing to guess about which shell should run the command. Also adds a test.
eg. --post-run-command 'go run contrib/notify/notify-macos.go'
dnephin
force-pushed
the
add-post-run-command
branch
from
75d8d28
to
8be9d46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74
Pass environment variables with some summary info.
Passing the path to the junit file and json file allows the script to read the full details from one of those files, however there would be lots of parsing required.
A JSON summary file with more parsed details would help, but requires some work to figure out the correct format.